Skip to content

update to the latest package:dart_flutter_team_lints #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

devoncarew
Copy link
Member

  • update to the latest package:dart_flutter_team_lints

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew
Copy link
Member Author

It looks like this may be a bug in the lint:

info - lib/src/registry.dart:13:13 - The referenced name isn't visible in scope. Try adding an import for the referenced name. - comment_references

from:

Screenshot 2023-09-28 at 12 37 27 PM

@devoncarew
Copy link
Member Author

Looks like the above issue is covered by dart-lang/sdk#59237.

@devoncarew devoncarew requested a review from jonasfj September 28, 2023 22:06
Copy link
Member

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, why all the const?

It's not like I'd care if these are constant or not, it just seems unnecessary.

@devoncarew
Copy link
Member Author

devoncarew commented Sep 29, 2023

Curious, why all the const?

It's not like I'd care if these are constant or not, it just seems unnecessary.

It's from this lint - prefer_const_constructors; very useful for flutter code and perf for widget trees. Sort of useful for regular dart code for communicating intent? There was some discussion here (when we added it to package:dart_flutter_team_lints). It's not one I' very invested in; the changes aren't bad, they're just not very necessary.

@devoncarew devoncarew merged commit b293897 into main Sep 29, 2023
@devoncarew devoncarew deleted the extension_discovery branch September 29, 2023 03:24
mosuem pushed a commit that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants