Update to oauth2 package README for Flutter Web info #1961

AbgarSim · 2025-01-10T14:07:43Z

Description:

This PR updates the README file of oauth2 package relating to the listen and redirect section. The reason being even though the provided information underlines that both listen and redirect are not the scopes of this library the provided example is both obsolete (uni_links is discontinued for app_links) and does not include Flutter Web ( neither web_views nor app_links can be used to implement the flow). As such I believe it could be useful to have a section mentioning how to use this library with Web.
There was an issue opened for this but the solution is still a bit unclear nor is it documented anywhere: #350

Solution

Changed uni_links to app_links reference.
Added a small section to README mentioning the approach for Flutter Web via creating an endpoint html file for redirect handle.

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

google-cla · 2025-01-10T14:07:48Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

github-actions · 2025-01-12T04:46:03Z

PR Health

Breaking changes ✔️

Package	Change	Current Version	New Version	Needed Version	Looking good?
oauth2	None	2.0.3	2.0.5	2.0.3	✔️

Changelog Entry ✔️

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️

File	Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbols

License Headers ✔️

// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers

Files
pkgs/bazel_worker/benchmark/benchmark.dart
pkgs/bazel_worker/example/client.dart
pkgs/bazel_worker/example/worker.dart
pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart
pkgs/boolean_selector/example/example.dart
pkgs/clock/lib/clock.dart
pkgs/clock/lib/src/clock.dart
pkgs/clock/lib/src/default.dart
pkgs/clock/lib/src/stopwatch.dart
pkgs/clock/lib/src/utils.dart
pkgs/clock/test/clock_test.dart
pkgs/clock/test/default_test.dart
pkgs/clock/test/stopwatch_test.dart
pkgs/clock/test/utils.dart
pkgs/coverage/lib/src/coverage_options.dart
pkgs/coverage/test/collect_coverage_config_test.dart
pkgs/coverage/test/config_file_locator_test.dart
pkgs/html/example/main.dart
pkgs/html/lib/dom.dart
pkgs/html/lib/dom_parsing.dart
pkgs/html/lib/html_escape.dart
pkgs/html/lib/parser.dart
pkgs/html/lib/src/constants.dart
pkgs/html/lib/src/encoding_parser.dart
pkgs/html/lib/src/html_input_stream.dart
pkgs/html/lib/src/list_proxy.dart
pkgs/html/lib/src/query_selector.dart
pkgs/html/lib/src/token.dart
pkgs/html/lib/src/tokenizer.dart
pkgs/html/lib/src/treebuilder.dart
pkgs/html/lib/src/utils.dart
pkgs/html/test/dom_test.dart
pkgs/html/test/parser_feature_test.dart
pkgs/html/test/parser_test.dart
pkgs/html/test/query_selector_test.dart
pkgs/html/test/selectors/level1_baseline_test.dart
pkgs/html/test/selectors/level1_lib.dart
pkgs/html/test/selectors/selectors.dart
pkgs/html/test/support.dart
pkgs/html/test/tokenizer_test.dart
pkgs/pubspec_parse/test/git_uri_test.dart
pkgs/stack_trace/example/example.dart
pkgs/watcher/test/custom_watcher_factory_test.dart
pkgs/yaml_edit/example/example.dart

github-actions · 2025-04-17T12:40:12Z

Package publishing

Package	Version	Status	Publish tag (post-merge)
package:bazel_worker	1.1.3	already published at pub.dev
package:benchmark_harness	2.3.1	already published at pub.dev
package:boolean_selector	2.1.2	already published at pub.dev
package:browser_launcher	1.1.3	already published at pub.dev
package:cli_config	0.2.1-wip	WIP (no publish necessary)
package:cli_util	0.4.2	already published at pub.dev
package:clock	1.1.2	already published at pub.dev
package:code_builder	4.10.2-wip	WIP (no publish necessary)
package:coverage	1.12.0	already published at pub.dev
package:csslib	1.0.2	already published at pub.dev
package:extension_discovery	2.1.0	already published at pub.dev
package:file	7.0.2-wip	WIP (no publish necessary)
package:file_testing	3.1.0-wip	WIP (no publish necessary)
package:glob	2.1.3	already published at pub.dev
package:graphs	2.3.3-wip	WIP (no publish necessary)
package:html	0.15.5+1	already published at pub.dev
package:io	1.1.0-wip	WIP (no publish necessary)
package:json_rpc_2	3.0.3	already published at pub.dev
package:markdown	7.3.1-wip	WIP (no publish necessary)
package:mime	2.0.0	already published at pub.dev
package:oauth2	2.0.5	ready to publish	`oauth2-v2.0.5`
package:package_config	2.3.0-wip	WIP (no publish necessary)
package:pool	1.5.2-wip	WIP (no publish necessary)
package:pub_semver	2.2.0	already published at pub.dev
package:pubspec_parse	1.5.0	already published at pub.dev
package:source_map_stack_trace	2.1.3-wip	WIP (no publish necessary)
package:source_maps	0.10.14-wip	WIP (no publish necessary)
package:source_span	1.10.1	already published at pub.dev
package:sse	4.1.8	ready to publish	`sse-v4.1.8`
package:stack_trace	1.12.1	already published at pub.dev
package:stream_channel	2.1.4	already published at pub.dev
package:stream_transform	2.1.2-wip	WIP (no publish necessary)
package:string_scanner	1.4.1	already published at pub.dev
package:term_glyph	1.2.3-wip	WIP (no publish necessary)
package:test_reflective_loader	0.2.3	already published at pub.dev
package:timing	1.0.2	already published at pub.dev
package:unified_analytics	8.0.1	already published at pub.dev
package:watcher	1.1.1	already published at pub.dev
package:yaml	3.1.3	already published at pub.dev
package:yaml_edit	2.2.2	already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

jonasfj · 2025-04-23T08:26:25Z

pkgs/oauth2/README.md

@@ -128,15 +128,16 @@ because different options exist for each platform.
 For Flutter apps, there's two popular approaches:

 1.  Launch a browser using [url_launcher][] and listen for a redirect using
-    [uni_links][].
+    [app_links][].


link referenced not defined

jonasfj · 2025-04-23T08:27:53Z

pkgs/oauth2/README.md

@@ -161,6 +162,46 @@ For Flutter apps, there's two popular approaches:
      );
    ```

+
+1.  To handle redirect on Flutter Web you would need to add a html file to the web folder with some 


Suggested change

1. To handle redirect on Flutter Web you would need to add a html file to the web folder with some

1. To handle redirect on Flutter Web you would need to add an html file to the web folder with some

jonasfj · 2025-04-23T08:28:43Z

pkgs/oauth2/README.md

+
+1.  To handle redirect on Flutter Web you would need to add a html file to the web folder with some 
+additional JS code to handle the redirect back to the app (in this example the code will be saved 
+and passed through localStorage).


This kind of depends on how you configure your oauth2 flow and what you're redirect URL is, doesn't it?

github-actions bot added the package:oauth2 label Jan 10, 2025

AbgarSim force-pushed the oauth2-readme branch 5 times, most recently from dffe5ac to c5f215a Compare January 10, 2025 21:11

Update to oauth2 package README for Flutter Web info

b7a4743

AbgarSim force-pushed the oauth2-readme branch from c5f215a to b7a4743 Compare January 13, 2025 11:28

Merge branch 'main' into oauth2-readme

a1954f5

mosuem requested a review from a team as a code owner April 17, 2025 12:39

jonasfj reviewed Apr 23, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to oauth2 package README for Flutter Web info #1961

Update to oauth2 package README for Flutter Web info #1961

AbgarSim commented Jan 10, 2025 •

edited

Loading

google-cla bot commented Jan 10, 2025

github-actions bot commented Jan 12, 2025 •

edited

Loading

github-actions bot commented Apr 17, 2025

jonasfj Apr 23, 2025

jonasfj Apr 23, 2025

jonasfj Apr 23, 2025

	1. To handle redirect on Flutter Web you would need to add a html file to the web folder with some
	1. To handle redirect on Flutter Web you would need to add an html file to the web folder with some

Update to oauth2 package README for Flutter Web info #1961

Are you sure you want to change the base?

Update to oauth2 package README for Flutter Web info #1961

Conversation

AbgarSim commented Jan 10, 2025 • edited Loading

Description:

Solution

google-cla bot commented Jan 10, 2025

github-actions bot commented Jan 12, 2025 • edited Loading

PR Health

github-actions bot commented Apr 17, 2025

Package publishing

jonasfj Apr 23, 2025

Choose a reason for hiding this comment

jonasfj Apr 23, 2025

Choose a reason for hiding this comment

jonasfj Apr 23, 2025

Choose a reason for hiding this comment

AbgarSim commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Jan 12, 2025 •

edited

Loading