-
Notifications
You must be signed in to change notification settings - Fork 50
[markdown] fix crash test #2067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Handle a case where the data could be null Also type the `getJson` function Also log a lot more often so the test doesn't seem hanged.
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
final u = Uri.tryParse(url); | ||
if (u == null) { | ||
return null; | ||
} | ||
try { | ||
final data = await c.read(u); | ||
try { | ||
return jsonDecode(data); | ||
return jsonDecode(data) as Map<String, dynamic>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible that pub.dev/api returns some other type of JSON, but in practice, they are always maps!
Another approach would be to return Object?
and force folks to cast. 🤷
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
Revisions updated by `dart tools/rev_sdk_deps.dart`. core (https://github.com/dart-lang/core/compare/7a80178..af37fe5): af37fe54 2025-04-04 Lasse R.H. Nielsen Adds `[Heap]PriorityQueue.of` constructor. (dart-lang/core#734) 635dfa32 2025-04-03 Kevin Moore [collection] explicitly make BoolList abstract interface (dart-lang/core#875) ecosystem (https://github.com/dart-lang/ecosystem/compare/391a80c..7f6f1c1): 7f6f1c1 2025-04-09 Daco Harkes [firehose] Fix dart_apitool invocations with pub workspaces (dart-lang/ecosystem#355) 0eb0349 2025-04-07 Moritz Fix tagging in publishing workflow (again) (dart-lang/ecosystem#353) 1ee8568 2025-04-07 Moritz Update README.md (dart-lang/ecosystem#352) http (https://github.com/dart-lang/http/compare/6fabf06..e4ddd3e): e4ddd3e 2025-04-07 Moritz Merge pull request `#1750` from dart-lang/fixTags 42b42e3 2025-04-07 Moritz Fix tags 54bf0f7 2025-04-07 Moritz Merge pull request `#1748` from dart-lang/fixPublish 84adca0 2025-04-04 Moritz Merge pull request `#1432` from dart-lang/fixHealth 8534a69 2025-04-04 Moritz Remove ignore breaking b80436a 2025-04-04 Moritz allow underscore 949cd87 2025-04-04 Moritz Fix publishing workflow 996c5d1 2024-12-17 Moritz ignore only for breaking changes e5321f7 2024-12-17 Moritz Update .github/workflows/health.yaml f902d8a 2024-12-17 Moritz typo 35f6e9a 2024-12-17 Moritz exclude websocket ca8caee 2024-12-17 Moritz Ignore http 621401e 2024-12-17 Moritz remove ignore license ce20b2a 2024-12-17 Moritz Fix health workflow test (https://github.com/dart-lang/test/compare/c1fa1e6..8643fbf): 8643fbf3 2025-04-09 Ömer Sinan Ağacan Migrate from deprecated `dart:js`, `dart:js_util`, `package:js_util` to `dart:js_interop` (dart-lang/test#2478) tools (https://github.com/dart-lang/tools/compare/b963bbf..d74f9e1): d74f9e13 2025-04-08 Loïc Sharma [UA] Add a Flutter event for plugins injected into an iOS/macOS project. (dart-lang/tools#2062) f34228f8 2025-04-08 Kevin Moore [graphs] fix readme CI badge (dart-lang/tools#2068) 0102cd63 2025-04-08 Kevin Moore [markdown] fix crash test (dart-lang/tools#2067) webdev (https://github.com/dart-lang/webdev/compare/697f2f7..c8b1cfa): c8b1cfa9 2025-04-07 Srujan Gaddam [dwds] Split hot reload callback into 2, disable breakpoints in changed files, and publish 24.3.10 (dart-lang/webdev#2606) 8d8413f5 2025-04-04 Wdestroier Support custom hostname and TLS options (dart-lang/webdev#2588) Change-Id: Idbad02c2087ceb3c7d0f7efcf0721f4806475e8e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/421542 Reviewed-by: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
Handle a case where the data could be null
Also type the
getJson
functionAlso log a lot more often so the test doesn't seem hanged.