-
Notifications
You must be signed in to change notification settings - Fork 53
Add DashEvent
for toggling telemetry collection + send event whenever toggled
#23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eliasyishak
merged 16 commits into
dart-lang:main
from
eliasyishak:22-add-dashevent-for-toggling-telemetry-collection
Mar 6, 2023
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
db28a4e
adding event for analyzer startup
eliasyishak f83f19c
switching from hyphens to underscore; GA4 restriction
eliasyishak 9d0dd2e
making eventData nullable for events that don't need it
eliasyishak f105267
Update dash_analytics_example.dart
eliasyishak 9825399
added test to check for limitations below
eliasyishak 2b26e92
Merge branch 'conforming-ga-limitations' into main
eliasyishak 16ba932
Merge branch 'main' of https://github.com/eliasyishak/tools
eliasyishak b16ffc5
Merge branch 'dart-lang:main' into main
eliasyishak 2aeebe5
Merge branch 'dart-lang:main' into main
eliasyishak 74838d1
Merge branch 'dart-lang:main' into main
eliasyishak a19d8bd
Empty commit
eliasyishak f35de81
Update enums.dart
eliasyishak 034fa11
Merge branch 'dart-lang:main' into main
eliasyishak 546b4b1
Merge branch 'dart-lang:main' into main
eliasyishak bdaf29e
Added new event + modified setTelemetry to send toggle status to GA
eliasyishak b5a4789
setTelemetry saves the event + tests added
eliasyishak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider extracting
(lastLogItem['events'] as List).last
as a helper or extension method, given that it occurs 4 times in this method alone.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll expand this out if an additional test needs this functionality