-
Notifications
You must be signed in to change notification settings - Fork 59
Refactoring to remove late variables and cyclic dependencies #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eliasyishak
merged 31 commits into
dart-lang:main
from
eliasyishak:remove-late-variables
Mar 25, 2024
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
1497f9e
Cleaned up `config_handler.dart`
eliasyishak d42be71
Cleaned up `log_handler.dart`
eliasyishak f985614
Cleaned up `session.dart`
eliasyishak f86338b
Clean up `survey_handler.dart`
eliasyishak 4b597f4
Confighandler no longer late variable
eliasyishak 5e93021
Remove `Initializer` dependency from `ConfigHandler`
eliasyishak 1640a33
Remove `late` variable for `_clientId`
eliasyishak dd9ffe4
Consolidate `Session` into `UserProperty`
eliasyishak 0052d71
Sort members + swap error messages for tests
eliasyishak 9394d29
`dart format .`
eliasyishak f0d110e
Fix tests + note a TODO for `package:file`
eliasyishak 173d5d8
`..run()`
eliasyishak d742315
Remove `UserProperty.initialize` method
eliasyishak 1aea010
Remove `ErrorHandler` + no late for userprop and loghandler
eliasyishak 75c560c
Fix test
eliasyishak 37fd0de
Make userprop variable private
eliasyishak f366922
Move configHandler to constructor initializer
eliasyishak 28807e4
Remove unnecessary parameters for log handler
eliasyishak 20f31c0
Add'l documentation
eliasyishak 227d5f5
Remove unused params for survey handler
eliasyishak 9415f98
Changelog update + dartdocs
eliasyishak 721a2c4
Bump version to `6.0.0`
eliasyishak 7b93ae2
Merge branch 'main' into remove-late-variables
eliasyishak a5fb177
Remove `Initializer` abstraction, sub for functions
eliasyishak 30623bc
Fix test for session file modified timestamp
eliasyishak 15950fa
Remove `sessionIdOverride` for session initializer
eliasyishak 5b4ae34
Clean up CHANGELOG
eliasyishak 7893a14
Merge branch 'main' into remove-late-variables
eliasyishak 1ff5e94
Merge remote-tracking branch 'upstream/main' into remove-late-variables
eliasyishak 37d29d7
Fix failing test
eliasyishak 75ec878
Format fix
eliasyishak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.