Rewrite the last_ping key again
#255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliasyishak
commented
Mar 14, 2024
Comment on lines
87
to
88
| sessionFile.writeAsStringSync( | ||
| '{"session_id": ${now.millisecondsSinceEpoch}, "last_ping": null}'); |
There was a problem hiding this comment.
Explanation for why I think this is necessary:
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
| @@ -85,7 +85,8 @@ class Initializer { | |||
| final now = sessionIdOverride ?? clock.now(); | |||
| sessionFile.createSync(recursive: true); | |||
| sessionFile | |||
| .writeAsStringSync('{"session_id": ${now.millisecondsSinceEpoch}}'); | |||
| .writeAsStringSync('{"session_id": ${now.millisecondsSinceEpoch}, ' | |||
| '"last_ping": ${now.millisecondsSinceEpoch}}'); | |||
There was a problem hiding this comment.
can we add a comment here that its deprecated?
| // Fallback to setting the session id as the current time | ||
| _sessionId = now.millisecondsSinceEpoch; | ||
| // ignore: avoid_catching_errors | ||
| } on TypeError catch (err) { |
There was a problem hiding this comment.
let's not catch TypeError, and instead be disciplined about never deleting fields from this JSON file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Not having the
last_pingkey in the session json file will cause issues if a user chooses to downgrade to a previous version of this package that attempts to parselast_ping. This PR adds that value backContribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.