Skip to content

Add a package-level config file #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nex3 opened this issue Mar 26, 2015 · 6 comments
Closed

Add a package-level config file #46

nex3 opened this issue Mar 26, 2015 · 6 comments
Labels
type-enhancement A request for a change that isn't a bug
Milestone

Comments

@nex3
Copy link
Member

nex3 commented Mar 26, 2015

As more and more aspects of tests become configurable in various ways, it will become necessary to have project-level configuration files. These might be used for configuration that would otherwise be included declaratively on tests, since if all tests would share the same configuration it would be a drag to mark it over and over again. They might also be used for configuration that would otherwise be passed on the command-line, to make it easy to provide custom defaults on a per-package basis.

Some things the config file should definitely support:

As time goes on, more configuration will likely be added as well.

@nex3 nex3 added the type-enhancement A request for a change that isn't a bug label Mar 26, 2015
@azenla
Copy link

azenla commented Mar 27, 2015

I take it this would be in YAML?

@nex3
Copy link
Member Author

nex3 commented Mar 27, 2015

Very likely.

@nex3 nex3 added this to the 1.0.0 milestone Mar 31, 2015
@zoechi
Copy link

zoechi commented Apr 9, 2015

It should be possible

  • to specify a specific configuration file using a command line argument.
  • configure a logging level (for example to suppress test log output)

@nex3
Copy link
Member Author

nex3 commented Apr 9, 2015

to specify a specific configuration file using a command line argument.

Agreed.

configure a logging level (for example to suppress test log output)

This is a separate feature request; it's out-of-scope for this issue.

@zoechi
Copy link

zoechi commented Apr 9, 2015

Could logging possibility be solved in a custom reporter when they are supported?

@nex3
Copy link
Member Author

nex3 commented Apr 9, 2015

Most of the output does come from the reporter. The test runner itself prints some errors for things like invalid command-line arguments, but anything that happens within a test is passed to the runner.

This was referenced Apr 21, 2015
nex3 added a commit that referenced this issue Feb 4, 2016
This just loads a subset of the config that can be pased on the command line
from the configuration file. The command line takes precedence over the config.

See #46

[email protected]

Review URL: https://codereview.chromium.org//1649663003 .
@nex3 nex3 closed this as completed in d31e2c5 Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants