Skip to content

Errors when hovering over enum values in VSCode during debugging #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
annagrin opened this issue Jan 20, 2021 · 1 comment
Open

Errors when hovering over enum values in VSCode during debugging #1226

annagrin opened this issue Jan 20, 2021 · 1 comment
Labels
metadata P3 A lower priority bug or feature request

Comments

@annagrin
Copy link
Contributor

annagrin commented Jan 20, 2021 •
edited
Loading

See the issue and repro in Dart-Code/Dart-Code#3082

According to the trace, it looks like dwds fails to find a library reference for dart:_runtime during getObject() call for id ("classes|dart:_runtime|_Type")

To solve this properly we need to communicate the list of implicitly imported libraries from dart_sdk to the debugger:

Part of: #1290
@DanTup DanTup mentioned this issue Jan 21, 2021
Closed
@annagrin annagrin mentioned this issue Mar 25, 2021
Open
@annagrin
Copy link
Contributor Author

annagrin commented Mar 26, 2021 •
edited
Loading

The issue is caused by missing implicit imports: dart-lang/sdk#45477, needs app-level metadata to resolve properly.
Working on a workaround for now (creating the missing metadata manually in the debugger).

This was referenced Mar 27, 2021
Open
Open
annagrin pushed a commit to annagrin/webdev that referenced this issue Mar 29, 2021
Update library heuristics as short term solution for missing metadata.
48c8b56 
- Return first `org-dartlang` library as `vmservice.rootLib`
  (or `main` if not found)
- Manually add dart_sdk module metadata in `MetadataProvider`.
- Update and add tests.

Helps: dart-lang/sdk#44760
Helps: dart-lang#1226
@annagrin annagrin mentioned this issue Mar 29, 2021
Merged
annagrin pushed a commit that referenced this issue Mar 30, 2021
Update library heuristics as short term solution for missing metadata. (
fe9aeac 
#1293)

* Update library heuristics as short term solution for missing metadata.

- Return first `org-dartlang` library as `vmservice.rootLib`
  (or `main` if not found)
- Manually add dart_sdk module metadata in `MetadataProvider`.
- Update and add tests.

Helps: dart-lang/sdk#44760
Helps: #1226

* Test fix

* Addressed CR comments
annagrin pushed a commit to annagrin/webdev that referenced this issue Apr 6, 2021
Update library heuristics as short term solution for missing metadata.
3e828e0 
- Return first `org-dartlang` library as `vmservice.rootLib`
  (or `main` if not found)
- Manually add dart_sdk module metadata in `MetadataProvider`.
- Update and add tests.

Helps: dart-lang/sdk#44760
Helps: dart-lang#1226
@annagrin annagrin removed the metadata label Sep 1, 2021
@annagrin annagrin mentioned this issue Sep 1, 2021
Open
@annagrin annagrin self-assigned this Sep 1, 2021
@annagrin annagrin changed the title Errors when hovering over types or enum values in VSCode during debugging Errors when hovering over enum values in VSCode during debugging Sep 1, 2021
@annagrin annagrin added the P3 A lower priority bug or feature request label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
metadata P3 A lower priority bug or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@annagrin