Skip to content

Support webkit inspection and prepare to publish #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Support webkit inspection and prepare to publish #1289

merged 2 commits into from
Mar 25, 2021

Conversation

grouma
Copy link
Member

@grouma grouma commented Mar 25, 2021

@google-cla google-cla bot added the cla: yes label Mar 25, 2021
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grouma grouma requested review from jacob314 and jakemac53 March 25, 2021 22:42
@@ -37,7 +37,7 @@ dependencies:
# We pin the version because we implement the interface.
vm_service: 6.1.0+1
web_socket_channel: ^2.0.0
webkit_inspection_protocol: ^0.7.4
webkit_inspection_protocol: ^1.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth expanding the constraint instead of bumping the lower bound?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't matter. This change is intended for Flutter Tools which requires the higher constraint.

@grouma grouma merged commit 18440bf into master Mar 25, 2021
@grouma grouma deleted the webkit branch March 25, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants