Display inherited fields #1307
Merged
Display inherited fields #1307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annagrin
approved these changes
Apr 20, 2021
| instance.fields.map((boundField) => boundField.decl.name).toList(); | ||
| expect(fieldNames, [ | ||
| '_privateField', | ||
| 'abstractField', |
Contributor
There was a problem hiding this comment.
would the private inherited fields show as well?
jacob314
reviewed
Apr 21, 2021
Member
jacob314
left a comment
jacob314
left a comment
There was a problem hiding this comment.
Please add a test for this code. That way you will break if DDC changed their naming convention for symbols that is depended on by the split(.).slice(-1)[0]
code.
Member
Author
I did add a test. I created an abstract class with a property. I ensure the property is visible in the extended class. If DDC changes the test will break. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dart-lang/sdk#45387
The JS object has inherited fields represented as
Symbols. Do a best effort collection of these fields.