Skip to content

Support hot restart for multi-ddr scenario #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Nov 2, 2021

  • Support hot restart in a multi-app scenario with legacy modules.

    • Rename $dartHotRestart in the injected client to $dartHotRestartDwds.
    • Make $dartHotRestartDwds take a runId.
    • No change in behavior for single applications.
    • For a multi-app scenario using legacy modules, this will make all
      sub-apps with the same runId restart at the same time once.

    Note that multi-app scenario is currently only supported for legacy modules,
    used by DDR, and is not yet supported for amd modules that are used by
    flutter tools and webdev.

Closes: #1431

@annagrin annagrin merged commit eb868f1 into dart-lang:master Nov 3, 2021
elliette pushed a commit to elliette/webdev that referenced this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multi-ddr hot restart
2 participants