Skip to content

Enable pkg:lints recommended lints #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Enable pkg:lints recommended lints #1444

merged 1 commit into from
Nov 11, 2021

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Nov 11, 2021

No description provided.

@kevmoo kevmoo requested review from annagrin and nshahan November 11, 2021 17:43
@google-cla google-cla bot added the cla: yes label Nov 11, 2021
Copy link
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but is there a reason we are not actually using the lints package here?

@kevmoo
Copy link
Member Author

kevmoo commented Nov 11, 2021

LGTM but is there a reason we are not actually using the lints package here?

It's a mono-repo. So you have to depend on a package from the root – or have every package copy-paste an analysis options file 🤷

@kevmoo kevmoo merged commit b8cc126 into master Nov 11, 2021
@kevmoo kevmoo deleted the lints branch November 11, 2021 18:44
elliette pushed a commit to elliette/webdev that referenced this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants