Skip to content

Bump vm_service to 7.4.0 #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Bump vm_service to 7.4.0 #1445

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d6fda7
Bump vm_service to 7.4.0
kenzieschmoll Nov 11, 2021
356859b
add todos
kenzieschmoll Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions dwds/lib/src/services/chrome_proxy_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,6 +1036,15 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension(
Future<Breakpoint> setBreakpointState(
String isolateId, String breakpointId, bool enable) =>
throw UnimplementedError();

@override
Future<UriList> lookupPackageUris(String isolateId, List<String> uris) =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these supposed to return? We may be able to implement it fairly easy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitions are here: https://github.com/dart-lang/sdk/blob/main/pkg/vm_service/lib/src/vm_service.dart#L927-L956. I'm only creating this PR because dwds is blocking the DevTools internal roll. Would it be acceptable to file a bug and add it as a TODO here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we should open a tracking issue. I'm fine moving forward to unblock the roll. cc @annagrin and @elliette

throw UnimplementedError();

@override
Future<UriList> lookupResolvedPackageUris(
String isolateId, List<String> uris) =>
throw UnimplementedError();
}

/// The `type`s of [ConsoleAPIEvent]s that are treated as `stderr` logs.
Expand Down
2 changes: 1 addition & 1 deletion dwds/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ dependencies:
sse: ^4.1.0
uuid: '>=2.0.0 <4.0.0'
# We pin the version because we implement the interface.
vm_service: 7.3.0
vm_service: 7.4.0
web_socket_channel: ^2.0.0
webkit_inspection_protocol: ^1.0.0

Expand Down