Skip to content

Fixed issues discovered in integration #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
annagrin merged 1 commit into from
Dec 16, 2021
Merged

Fixed issues discovered in integration #1469

annagrin merged 1 commit into from
Dec 16, 2021

Conversation

@annagrin
Copy link
Contributor

@annagrin annagrin commented Dec 16, 2021 •
edited
Loading

  • Some scenarios require libraries.json to be a different path from the
    SDK installation directory, update DartUri and ExpressionCompilerService
    to allow for that.
  • Fix a bug where dartEmitDebugEvents was set as a String instead of
    bool in the injected client.

Fixed issues discovered in integration
51e96a4 
- some scenarios require libraries.json to be a different path from the
  SDK installation directory, update DartUri and ExpressionCompilerService
  to allow for that.
- Fix a bug where `dartEmitDebugEvents` was set as a `String` instead of
  `bool` in the injected client.
@annagrin annagrin requested review from elliette and nshahan December 16, 2021 22:53
@annagrin annagrin merged commit 07d1034 into dart-lang:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elliette elliette elliette approved these changes

@nshahan nshahan Awaiting requested review from nshahan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@annagrin @elliette