Skip to content

Refactor background.dart in Dart Debug Extension #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 18, 2022

Conversation

elliette
Copy link
Contributor

This shouldn't affect or change any functionality. This is simply a refactor of the background.dart file to make it easier to read and understand.

The changes are:

  1. Switch anonymous function callbacks to named functions so it's easier to understand what they are doing
  2. Re-use some of the named functions in multiple places to reduce code duplication
  3. Add lots of comments

@elliette elliette requested a review from annagrin January 4, 2022 18:57
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Elliott, great readability changes! Add some comments to possibly add more.

Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you Elliott, this is much easier to read! LGTM!

@elliette elliette merged commit 4655961 into dart-lang:master Jan 18, 2022
@elliette elliette deleted the extension-refactor branch May 4, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants