Add option to launch DevTools in the same Chrome window #1481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annagrin
suggested changes
Jan 7, 2022
|
FYI - the test failure could be caused by the bad DDS update that we encountered last week. It should be fixed now, so rerunning the tests might help. |
annagrin
suggested changes
Jan 10, 2022
dwds/CHANGELOG.md
Outdated
| @@ -11,6 +11,7 @@ | |||
| - Remove dead code for reading `'dart.developer.registerExtension'` and | |||
| `'dart.developer.postEvent'` events from the chrome console. These messages | |||
| haven't been written to the console since dwds v11.1.0 and Dart SDK v2.14.0. | |||
| - Add an option to launch Dart DevTools in the same window as the connected Dart app. | |||
There was a problem hiding this comment.
Since it is a breaking change, could you please move it to the section below and describe it as an additional parameter to dwds.start?
There was a problem hiding this comment.
Moved it to the section below and updated the comment!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few customers requested the ability to launch Dart DevTools in the same Chrome window as their Dart application. Currently we only launch Dart DevTools from a different Chrome window, this adds the ability to launch it from the same window.