Skip to content

Migrate .packages to package_config #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Migrate .packages to package_config #1537

wants to merge 10 commits into from

Conversation

elliette
Copy link
Contributor

See #1526

@elliette elliette requested review from grouma and annagrin March 10, 2022 20:41
annagrin
annagrin suggested changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Elliott! frontend_server_common package is also using .packages files, you would need to change those as well (used in test setup, so it causes the tests to fail)

@annagrin
Copy link
Contributor

annagrin commented Mar 18, 2022 •
edited
Loading

@elliette I have a draft that fixes fronted_server_common issue (mapping of file paths to uri's was done using .packages, changed it to use package_config) - #1543

@annagrin
Copy link
Contributor

replaced by #1543

@annagrin annagrin closed this Mar 22, 2022
@elliette elliette deleted the package-config branch May 4, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annagrin annagrin annagrin requested changes

@grouma grouma grouma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elliette @annagrin @grouma