Skip to content

Fix breakpoints not hitting after changing a base in index.html. #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 21, 2022
Merged

Fix breakpoints not hitting after changing a base in index.html. #1556

merged 13 commits into from
Apr 21, 2022

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Apr 4, 2022 •
edited
Loading

Fix breakpoints not hitting after changing a base in index.html.

  • Add basePath parameter to FrontendServerRequireStrategy.
    • Adjust the server paths to start with the base path.
  • Adjust server paths in DartUri to start with the base path.
  • Add helpers to require.dart
  • Removed test that is not reflecting actual scenarios.

Closes: #1554

@annagrin annagrin requested a review from elliette April 20, 2022 21:34
natebosch
natebosch reviewed Apr 20, 2022
View reviewed changes
@annagrin annagrin requested a review from natebosch April 21, 2022 01:10
@annagrin annagrin merged commit 881a4f8 into dart-lang:master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebosch natebosch natebosch approved these changes

@elliette elliette Awaiting requested review from elliette

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dwds fails to set breakpoints with non-default base url
2 participants
@annagrin @natebosch