Skip to content

Make error message in Dart Debug Extension more specific #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 3, 2022
Merged

Make error message in Dart Debug Extension more specific #1583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f5681d
Fix error message in debug extension
elliette Apr 14, 2022
3731f60
Update version
elliette Apr 14, 2022
37f0d35
Merge in master
elliette Apr 19, 2022
8da64e6
Merge branch 'master' into host-apps-error
elliette May 2, 2022
c01176b
Remove extra spaces
elliette May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dwds/debug_extension/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## 1.29

- Notify the debugger and inspector panels when the debug session is disconnected.
- Provide a detailed error message when the debugger fails to connect.

## 1.28

Expand Down
7 changes: 4 additions & 3 deletions dwds/debug_extension/web/background.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@ import 'package:sse/client/sse_client.dart';
import 'package:web_socket_channel/web_socket_channel.dart';

const _notADartAppAlert = 'No Dart application detected.'
' Your development server should inject metadata to indicate support for'
' Dart debugging. This may require setting a flag. Check the documentation'
' for your development server.';
' Are you trying to debug an application that includes a Chrome hosted app'
' (an application listed in chrome://apps)? If so, debugging is disabled.'
' You can fix this by removing the application from chrome://apps. Please'
' see https://bugs.chromium.org/p/chromium/issues/detail?id=885025#c11.';

// Extensions allowed for cross-extension communication.
const _allowedExtensions = {
Expand Down
Loading