Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dwds/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
## 14.0.1-dev
- Add `libraryFilters` optional parameter to the vm service implememtation
of `getSourceReport`.
- Update temp variable detection heuristics so internal JS type objects do
not show in the debugger.

## 14.0.0
- Add column information to breakpoints to allow precise breakpoint placement.
Expand Down
2 changes: 1 addition & 1 deletion dwds/lib/src/debugging/dart_scope.dart
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import 'debugger.dart';

// TODO(sdk/issues/44262) - use an alternative way to identify synthetic
// variables.
final ddcTemporaryVariableRegExp = RegExp(r'^(t[0-9]+\$?[0-9]*|__t\$\w*)$');
final ddcTemporaryVariableRegExp = RegExp(r'^(t[0-9]+\$?[0-9]*|__t[\$\w*]+)$');

/// Find the visible Dart properties from a JS Scope Chain, coming from the
/// scopeChain attribute of a Chrome CallFrame corresponding to [frame].
Expand Down
2 changes: 2 additions & 0 deletions dwds/test/variable_scope_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ void main() {
expect(ddcTemporaryVariableRegExp.hasMatch(r't10'), isTrue);
expect(ddcTemporaryVariableRegExp.hasMatch(r'__t$TL'), isTrue);
expect(ddcTemporaryVariableRegExp.hasMatch(r'__t$StringN'), isTrue);
expect(ddcTemporaryVariableRegExp.hasMatch(r'__t$IdentityMapOfString$T'),
isTrue);

expect(ddcTemporaryVariableRegExp.hasMatch(r't'), isFalse);
expect(ddcTemporaryVariableRegExp.hasMatch(r't10foo'), isFalse);
Expand Down