Migrate debugger_test and instance_test to null-safety
#1708
Conversation
elliette
changed the title
debugger_test, inspector_test, and instance_test to null-safetydebugger_test and instance_test to null-safety
| @@ -163,29 +161,4 @@ void main() async { | |||
| expect(frames[3].kind, FrameKind.kAsyncSuspensionMarker); | |||
| expect(frames[4].kind, FrameKind.kAsyncCausal); | |||
| }); | |||
|
|
|||
| group('errors', () { | |||
There was a problem hiding this comment.
Removed because all this was checking was whether an error would be thrown if a null value was passed as a parameter (when a null value wasn't expected). With null-safety, this isn't possible.
There was a problem hiding this comment.
I think the idea was to test that the error message is shown, passing the null was just the way to trigger it. Is there any other way to trigger the errors in the debugger? Maybe throwing somewhere in the fake inspector code? Or by introducing a fake stack computer that throws when calculating frames?
There was a problem hiding this comment.
Added test back in, thanks!
| @@ -163,29 +161,4 @@ void main() async { | |||
| expect(frames[3].kind, FrameKind.kAsyncSuspensionMarker); | |||
| expect(frames[4].kind, FrameKind.kAsyncCausal); | |||
| }); | |||
|
|
|||
| group('errors', () { | |||
There was a problem hiding this comment.
I think the idea was to test that the error message is shown, passing the null was just the way to trigger it. Is there any other way to trigger the errors in the debugger? Maybe throwing somewhere in the fake inspector code? Or by introducing a fake stack computer that throws when calculating frames?
I did not refactor away the null-assert
!s added by the Dart migration tool. Because this is a test, the null-assert!s should catch any regressions if something we expect to be non-null returns null.