Migrate asset_handler_test to null-safety
#1710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
changed the title
asset_handler testasset_handler_test to null-safety
annagrin
approved these changes
Aug 4, 2022
| await tabConnection.runtime.enable(); | ||
| await tabConnection.debugger.enable(); | ||
| final tab = await connection.getTab((t) => t.url == appUrl); | ||
| if (tab != null) { |
There was a problem hiding this comment.
We should throw if tab is not found, the tests won't run properly in that case.
| @@ -55,7 +55,7 @@ class DwdsVmClient { | |||
| '$request'); | |||
| return; | |||
| } | |||
| requestController.sink.add(jsonDecode(request) as Map<String, Object>); | |||
| requestController.sink.add(Map<String, Object>.from(jsonDecode(request))); | |||
There was a problem hiding this comment.
I wonder if it is necessary to create a new object here (possible performance hit?)
There was a problem hiding this comment.
I'm not sure of another way - jsonDecode returns dynamic, so using as to cast is throwing a type error (as should only be used "if and only if you are sure that the object is of that type": https://dart.dev/guides/language/language-tour#type-test-operators)
| @@ -53,7 +53,7 @@ void Function(WebSocketChannel, String) _createNewConnectionHandler( | |||
| 'Got value with unexpected type ${value.runtimeType} from web ' | |||
| 'socket, expected a List<int> or String.'); | |||
| } | |||
| final request = jsonDecode(value as String) as Map<String, Object>; | |||
| final request = Map<String, Object>.from(jsonDecode(value)); | |||
There was a problem hiding this comment.
Is the new object necessary here as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.