Skip to content

Temporarily disable listview_test.dart #1742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2022
Merged

Temporarily disable listview_test.dart #1742

merged 1 commit into from
Sep 7, 2022

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Sep 7, 2022

See #1741

Note: Formatting changes due to running dart format on file

@elliette elliette requested a review from annagrin September 7, 2022 17:59
@annagrin
Copy link
Contributor

annagrin commented Sep 7, 2022

LGTM! We probably should disable and open a bug for this flaky tests on windows as well:
❌ test\chrome_proxy_service_test.dart: shared context getStack throws if not paused (failed)

annagrin
annagrin approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit 539dd2d into dart-lang:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annagrin annagrin annagrin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliette @annagrin