Batch evaluation requests when possible #1746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grouma
approved these changes
Sep 12, 2022
| _logger.fine('Evaluating batch of expressions $batchedExpression'); | ||
|
|
||
| final RemoteObject list = await super.evaluateExpression( | ||
| first.isolateId, first.libraryUri, batchedExpression, first.scope); |
There was a problem hiding this comment.
So this doesn't require changes to the Dart Debug Extension? If so, neat!
There was a problem hiding this comment.
Yep I wanted to make it transparent to the user - the only requirement is that the requests are done in parallel, as opposed to awaiting for one to finish before firing another.
This was referenced Sep 15, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expression evaluation performance improvement:
ChromeProxyService.evaluate()requests that are close in timeand are executed in the same library and scope.
Closes: #1747