Skip to content

Update analysis options in dwds #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion dwds/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,15 @@ include: package:lints/recommended.yaml

analyzer:
exclude:
# Ignore generated files
# Ignore generated files
- "lib/data/*"
# Ignore debug extension builds
- "debug_extension/dev_build/*"
- "debug_extension/prod_build/*"
- "debug_extension_mv3/dev_build/*"
- "debug_extension_mv3/prod_build/*"

linter:
rules:
- prefer_final_locals
- unawaited_futures
6 changes: 3 additions & 3 deletions dwds/debug_extension/tool/update_dev_files.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

import 'dart:async';
import 'dart:io';

void main() async {
_updateManifestJson();
_updateDevtoolsJs();
await Future.wait([_updateManifestJson(), _updateDevtoolsJs()]);
}

/// Adds the Googler extension key, updates the extension icon, and prefixes the
Expand All @@ -17,7 +17,7 @@ Future<void> _updateManifestJson() async {
final extensionKey = await extensionKeyTxt.exists()
? await extensionKeyTxt.readAsString()
: null;
_transformDevFile(manifestJson, (line) {
return _transformDevFile(manifestJson, (line) {
if (_matchesKey(line: line, key: 'name')) {
return [
_newKeyValue(
Expand Down
5 changes: 3 additions & 2 deletions dwds/debug_extension_mv3/tool/update_dev_files.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

import 'dart:async';
import 'dart:io';

void main() async {
_updateManifestJson();
await _updateManifestJson();
}

/// Adds the Googler extension key.
Expand All @@ -15,7 +16,7 @@ Future<void> _updateManifestJson() async {
final extensionKey = await extensionKeyTxt.exists()
? await extensionKeyTxt.readAsString()
: null;
_transformDevFile(manifestJson, (line) {
return _transformDevFile(manifestJson, (line) {
if (_matchesKey(line: line, key: 'name')) {
return [
line,
Expand Down
4 changes: 2 additions & 2 deletions dwds/lib/src/services/batched_expression_evaluator.dart
Original file line number Diff line number Diff line change
Expand Up @@ -121,15 +121,15 @@ class BatchedExpressionEvaluator extends ExpressionEvaluator {
final request = requests[i];
if (request.completer.isCompleted) continue;
_logger.fine('Getting result out of a batch for ${request.expression}');
_debugger
unawaited(_debugger
.getProperties(list.objectId!,
offset: i, count: 1, length: requests.length)
.then((v) {
final result = v.first.value;
_logger.fine(
'Got result out of a batch for ${request.expression}: $result');
request.completer.complete(result);
});
}));
}
}
}