Log entire exception message instead of first line

[elliette]

Fixes #1781

See flutter/flutter#114727 (comment) for details

[annagrin]

Thanks Elliott! I wonder how the changes will behave on normal exception traces (multi-line ones especially).

[annagrin]

I think we need more tests here - how about adding examples of regular stack traces in exceptions that a program throws, with multiple stack frames?

[annagrin]

Here is an example of an exception description when I add throw Exception(blah at blahblah') to a dart web program:

Error: Exception: blah at blahblah
    at Object.throw_ [as throw] (http://127.0.0.1:56165/packages/build_web_compilers/src/dev_compiler/dart_sdk.js:5014:11)
    at main$ (http://127.0.0.1:56165/main.unsound.ddc.js:53:15)
at http://127.0.0.1:56165/main.dart.bootstrap.js:267:10
    at Array.forEach (<anonymous>)
at window.$dartRunMain (http://127.0.0.1:56165/main.dart.bootstrap.js:266:32)
    at <anonymous>:1:8
    at Object.runMain (http://127.0.0.1:56165/dwds/src/injected/client.js:8825:21)
    at http://127.0.0.1:56165/dwds/src/injected/client.js:25106:19
    at _wrapJsFunctionForAsync_closure.$protected (http://127.0.0.1:56165/dwds/src/injected/client.js:3448:15)
    at _wrapJsFunctionForAsync_closure.call$2 (http://127.0.0.1:56165/dwds/src/injected/client.js:11529:12)
    at Object._asyncStartSync (http://127.0.0.1:56165/dwds/src/injected/client.js:3412:20)
    at main__closure4.$call$body$main__closure (http://127.0.0.1:56165/dwds/src/injected/client.js:25122:16)
    at main__closure4.call$1 (http://127.0.0.1:56165/dwds/src/injected/client.js:25034:19)
    at StaticClosure._rootRunUnary (http://127.0.0.1:56165/dwds/src/injected/client.js:3816:16)
    at _CustomZone.runUnary$2$2 (http://127.0.0.1:56165/dwds/src/injected/client.js:12928:39)
    at _CustomZone.runUnaryGuarded$1$2 (http://127.0.0.1:56165/dwds/src/injected/client.js:12875:14)
    at _ControllerSubscription._sendData$1 (http://127.0.0.1:56165/dwds/src/injected/client.js:12468:19)
    at _DelayedData.perform$1 (http://127.0.0.1:56165/dwds/src/injected/client.js:12651:59)
    at _PendingEvents_schedule_closure.call$0 (http://127.0.0.1:56165/dwds/src/injected/client.js:12710:14)
    at Object._microtaskLoop (http://127.0.0.1:56165/dwds/src/injected/client.js:3656:24)
    at StaticClosure._startMicrotaskLoop (http://127.0.0.1:56165/dwds/src/injected/client.js:3662:11)
    at _AsyncRun__initializeScheduleImmediate_internalCallback.call$1 (http://127.0.0.1:56165/dwds/src/injected/client.js:11406:9)
    at invokeClosure (http://127.0.0.1:56165/dwds/src/injected/client.js:1227:26)
    at MutationObserver.<anonymous> (http://127.0.0.1:56165/dwds/src/injected/client.js:1246:18)

[annagrin]

And here is the same exception mapped to dart (we need to fix that translation it seems but this is another issue):

Error: Exception: blah at blahblah
dart:sdk_internal 5014:11             throw_
main.dart 20:3                        main$
main.dart.bootstrap.js 267:10         <fn>
main.dart.bootstrap.js 266:32         $dartRunMain
%3Canonymous%3E 1:8                   <fn>
dwds/src/injected/client.js 8825:21   runMain
dwds/src/injected/client.js 25106:19  <fn>
dwds/src/injected/client.js 3448:15   $protected
dwds/src/injected/client.js 11529:12  call$2
dwds/src/injected/client.js 3412:20   _asyncStartSync
dwds/src/injected/client.js 25122:16  $call$body$main__closure
dwds/src/injected/client.js 25034:19  call$1
dwds/src/injected/client.js 3816:16   _rootRunUnary
dwds/src/injected/client.js 12928:39  runUnary$2$2
dwds/src/injected/client.js 12875:14  runUnaryGuarded$1$2
dwds/src/injected/client.js 12468:19  _sendData$1
dwds/src/injected/client.js 12651:59  perform$1
dwds/src/injected/client.js 12710:14  call$0
dwds/src/injected/client.js 3656:24   _microtaskLoop
dwds/src/injected/client.js 3662:11   _startMicrotaskLoop
dwds/src/injected/client.js 11406:9   call$1
dwds/src/injected/client.js 1227:26   invokeClosure
dwds/src/injected/client.js 1246:18   <fn>

[elliette]

Good suggestion! Added a few more test cases

[annagrin]

LGTM!