Save debug information in chrome.storage after a Dart app loads
#1791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
changed the title
chrome.storage after a Dart app loads chrome.storage after a Dart app loads
annagrin
approved these changes
Nov 18, 2022
| final worker = (await serviceWorkerTarget.worker)!; | ||
| // Note: The following delay is required to reduce flakiness (it makes | ||
| // sure the execution context is ready): | ||
| await Future.delayed(Duration(seconds: 1)); |
There was a problem hiding this comment.
Is 1 second enough time to guarantee that the context is ready, or should we try a few times? Btw, is there a way to reliably check that is ready?
There was a problem hiding this comment.
I ran this multiple times to confirm (same timeout as the other test case). I've moved the timeout itself into a const variable for both so if we do end up changing it we can just change it in one place. When I first added this, I tried explicitly waiting on the worker's execution context, but that wasn't enough to prevent the flakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.