Skip to content

File paths in TestContext are relative, not absolute #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 20, 2022
Merged

File paths in TestContext are relative, not absolute #1843

merged 3 commits into from
Dec 20, 2022

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Dec 19, 2022 •
edited
Loading

Work towards #1842

Addresses 2) of the above:

We are treating the default TestContext directory as a relative directory from the current path. However, we are not doing the same for a directory that is passed in as a parameter (we assume that it is an absolute directory, although none of them are actually absolute. See for example dart_uri_file_uri_test)

This PR treats all directory / file paths in TestContext as relative paths.

@elliette elliette marked this pull request as ready for review December 20, 2022 00:19
@elliette elliette changed the title Another attempt at resolving failing tests File paths in TestContext are relative, not absolute Dec 20, 2022
@elliette elliette merged commit 80f8671 into dart-lang:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polina-c polina-c polina-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliette @polina-c