Return RPCError.kMethodNotFound for streamCpuSamplesWithUserTag
#1889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jan 13, 2023
…rTag` DWDS does not implement streamCpuSamplesWithUserTag and DDS can invoke it without being prompted to by a client. This change gracefully handles the absence of this RPC. Related DWDS change: dart-lang/webdev#1889 Change-Id: Ic821f39caefd25044c2c4a8b34a8271879c7bd5f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279020 Reviewed-by: Elliott Brooks <[email protected]> Commit-Queue: Ben Konyi <[email protected]>
elliette
changed the title
RPCError.kMethodNotFound for streamCpuSamplesWithUserTagRPCError.kMethodNotFound for streamCpuSamplesWithUserTag
elliette
changed the title
RPCError.kMethodNotFound for streamCpuSamplesWithUserTagRPCError.kMethodNotFound for streamCpuSamplesWithUserTag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #1504:
Also requires DDS (the client in this case) to catch these error response, similar to what is done for
setStreamIncludePrivateMembers: https://github.com/dart-lang/sdk/blob/55ffa4a4a3fe65b78ff6d43b72ab7907f3fa0145/pkg/dds/lib/src/stream_manager.dart#L245