Skip to content

[MV3] Debug session persists across closing and opening Chrome DevTools #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 14, 2023

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Jan 14, 2023

Fixes a bug that was caught while bug-bashing the new MV3 extension.

If you open Chrome DevTools, launch the debugger, close Chrome DevTools, and then re-open it, you should be able to continue debugging.

Unfortunately I'm not sure how to write a test for this. Puppeteer (and ChromeDriver) only lets you set whether Chrome DevTools is open on launching the browser, there is no way to close and then reopen it.

@elliette elliette requested a review from annagrin January 14, 2023 00:41
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit f978b90 into dart-lang:master Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants