Skip to content

Fix asset handler tests #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 14, 2023

Conversation

annagrin
Copy link
Contributor

The asset handler tests are failing silently after the SDK changes to null safety by default. The test don't have a check for the response status to validate that the file was found). Add the checks and update the file names to match null safety by default.

Towards: #1818

@annagrin annagrin requested a review from elliette February 13, 2023 22:11
@annagrin annagrin merged commit 7cf8fe2 into dart-lang:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants