Skip to content

[MV3 Debug Extension] Show a warning if multiple Dart apps are in a single page #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 21, 2023

Conversation

elliette
Copy link
Contributor

No description provided.

@elliette elliette requested a review from annagrin February 21, 2023 21:53
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of asks

@@ -143,6 +155,16 @@ void _handleDevToolsUriChanges(String? devToolsUri) async {
}
}

void _maybeShowMultipleAppsWarning(String? multipleApps) async {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future<void> (there are more like that below)

}
}
}

void _maybeUpdateFileABugLink() async {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future<void>

@elliette elliette merged commit 705e0ac into dart-lang:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants