Fix exception mapping from JS to dart - #2004
Merged
annagrin merged 22 commits intoMar 6, 2023
Merged
Conversation
added 16 commits
February 24, 2023 11:20
elliette
reviewed
Mar 1, 2023
elliette
approved these changes
Mar 1, 2023
elliette
left a comment
elliette
left a comment
Contributor
There was a problem hiding this comment.
Approved with one comment to resolve
nshahan
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A prior SDK change introduced a regression - exception mapping stopped working due detection in DWDS relying on type signatures for exceptions.
Allow all subtypes of
NativeErroras exceptions.Closes: #1821