Skip to content

Dart Code Metrics follow-up #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elliette merged 2 commits into from
Apr 7, 2023
Merged

Dart Code Metrics follow-up #2072

elliette merged 2 commits into from
Apr 7, 2023

Conversation

@elliette
Copy link
Contributor

@elliette elliette commented Apr 4, 2023

@elliette elliette requested review from annagrin and jacob314 April 4, 2023 18:44
@elliette elliette mentioned this pull request Apr 4, 2023
Merged
annagrin
annagrin approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jacob314
jacob314 approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elliette elliette merged commit d6b3e9c into dart-lang:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jacob314 jacob314 jacob314 approved these changes

@annagrin annagrin annagrin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dart-debug-extension package:dwds

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elliette @jacob314 @annagrin