Refactor record shape processing out of calculating record bound fields - #2074
Merged
Merged
Conversation
annagrin
changed the title
elliette
approved these changes
Apr 6, 2023
jacob314
reviewed
Apr 13, 2023
| function() { | ||
| var sdkUtils = ${globalLoadStrategy.loadModuleSnippet}('dart_sdk').dart; | ||
| var shape = sdkUtils.dloadRepl(this, "shape"); | ||
| var positionalCount = sdkUtils.dloadRepl(shape, "positionals"); |
Member
There was a problem hiding this comment.
why are the Repl versions of these dload calls used? The repl and regular versions should be identical because the fields are not private but it appears we are using the wrong version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record shapes can be used in other places such as RecordTypes. Refactor the code for record shape processing out of code calculating record bound fields so we can potentially reuse it for RecordTypes.
See: #2070