Add a test to make sure proper release procedure is followed for dwds and webdev
#2095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package:dwds
type-infra
elliette
changed the title
dwds and webdev
natebosch
approved these changes
Apr 18, 2023
| absolutePath(pathFromWebdev: p.join(package, 'pubspec.yaml')); | ||
| final pubspec = Pubspec.parse(File(pubspecPath).readAsStringSync()); | ||
| final version = pubspec.version!; | ||
| final isDev = version.toString().contains('dev'); |
There was a problem hiding this comment.
Sorry for the churn, but I think we're updating our recommendation from using -dev to using -wip
There was a problem hiding this comment.
Switched it over, thanks!
jakemac53
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #2085
Adds a check to make that
dwdsandwebdevget released after a PR preparing them for release is landed. Also verifies that the repos are then reset before more changes can be landed.Switches not-yet-published version to using
-wipsuffix instead of-devsuffix to follow naming conventions suggested in dart-lang/site-www#2453