Skip to content

Prep DWDS for next release (24.2.0-wip) and get presubmit checks working again #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Prep DWDS for next release (24.2.0-wip) and get presubmit checks working again #2485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
16a8f03
Prep DWDS for next release (24.2.0-wip)
bkonyi Aug 28, 2024
6d27975
Fix release
bkonyi Aug 28, 2024
2406379
Formatting?
bkonyi Aug 28, 2024
67622ab
[DWDS] Make TestContext.setUp set the --disable-gpu Chrome option whe…
derekxu16 Sep 3, 2024
63b5482
[DWDS] Skip frontend_server_ddc_and_canary_evaluate_test.dart
derekxu16 Sep 4, 2024
fac5272
[webdev] Skip cases in webdev/test/e2e_test.dart that are failing on …
derekxu16 Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dwds/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
## 24.2.0-wip

## 24.1.0

- Fix bug where debugging clients are not aware of service extensions when connecting to a new web app. - [#2388](https://github.com/dart-lang/webdev/pull/2388)
Expand Down
5 changes: 2 additions & 3 deletions dwds/lib/src/debugging/instance.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,9 +268,8 @@ class InstanceHelper extends Domain {
objectId,
offset: offset,
count: count,
length: metaData.kind != InstanceKind.kPlainInstance
? metaData.length
: null,
length:
metaData.kind != InstanceKind.kPlainInstance ? metaData.length : null,
);

final dartProperties = await _dartFieldsFor(properties, remoteObject);
Expand Down
Loading
Loading