Prefer installation as a dev-dependency#2511
Open
sigurdm wants to merge 5 commits intodart-lang:mainfrom
Open
Conversation
bkonyi
reviewed
Nov 19, 2024
Collaborator
bkonyi
left a comment
bkonyi
left a comment
There was a problem hiding this comment.
Does this remove the build_runner and build_web_compilers dependency checks? That makes me nervous since we'll still have the majority of users running dart pub global activate webdev to install webdev out of habit or based on tutorials. How will the globally activated webdev flow fail now if these dependencies aren't present?
If we can detect whether or not webdev has been installed as a dev dependency or a global package, can we keep these checks?
|
|
||
| dependency_overrides: | ||
| dwds: | ||
| path: ../dwds No newline at end of file |
Collaborator
There was a problem hiding this comment.
Nit: this needs a trailing newline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2497
Removes the version checks of pubspec.lock. These now come "for free" by virtue of the pub version solver.