Skip to content

Add extra step for DDC library bundle format #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add extra step for DDC library bundle format #2615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions dwds/test/common/chrome_proxy_service_common.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import 'package:path/path.dart' as path;
import 'package:test/test.dart';
import 'package:test_common/logging.dart';
import 'package:test_common/test_sdk_configuration.dart';
import 'package:test_common/utilities.dart';
import 'package:vm_service/vm_service.dart';
import 'package:vm_service_interface/vm_service_interface.dart';

Expand Down Expand Up @@ -1580,6 +1581,20 @@ void runTests({
});

test('Into goes to the next Dart location', () async {
if (dartSdkIsAtLeast('3.9.0-88.0.dev') &&
moduleFormat == ModuleFormat.ddc &&
canaryFeatures) {
// With the DDC library bundle format, there's a comparison against
// the hot reload generation to avoid emitting extra checks before
// `printCount` is called. We need to step past that code before we
// get to `printCount`. See
// https://github.com/dart-lang/sdk/commit/6127d6cb8f3de7451f78b21ec9a7cb7350e77252
// for more details.
await service.resume(isolateId!, step: 'Into');
await stream.firstWhere(
(event) => event.kind == EventKind.kPauseInterrupted,
);
}
await service.resume(isolateId!, step: 'Into');
// Wait for the step to actually occur.
await stream.firstWhere(
Expand Down
Loading