Handle out of order disconnects and reconnects.#2757
Open
justtonytone wants to merge 1 commit intodart-lang:mainfrom
Open
Handle out of order disconnects and reconnects.#2757justtonytone wants to merge 1 commit intodart-lang:mainfrom
justtonytone wants to merge 1 commit intodart-lang:mainfrom
Conversation
Author
|
Requires dart-lang/tools#2305 |
62b34de to
0f9621b
Compare
justtonytone
commented
Jan 23, 2026
| stack_trace: ^1.10.0 | ||
| stream_channel: ^2.1.2 | ||
| sse: ^4.1.2 | ||
| sse: ^4.2.0 |
Author
There was a problem hiding this comment.
I would've expected this to fail since sse is only on 4.1.8, is there some kind of presubmit here that tries to run a build?
Collaborator
There was a problem hiding this comment.
Yes, but we need to approve the workflows to run since you're not a trusted contributor on the repository. They'd definitely fail :)
- Update dwds to support ignoring disconnects for the SseHandler - This is useful to prevent incorrect behavior when a disconnect event arrives after a new connection request
0f9621b to
b25b197
Compare
nshahan
reviewed
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.