Skip to content

Handle out of order disconnects and reconnects.#2757

Open
justtonytone wants to merge 1 commit intodart-lang:mainfrom
justtonytone:b-469149126-hot-reload-issues
Open

Handle out of order disconnects and reconnects.#2757
justtonytone wants to merge 1 commit intodart-lang:mainfrom
justtonytone:b-469149126-hot-reload-issues

Conversation

@justtonytone
Copy link

  • Update dwds to support ignoring disconnects for the SseHandler
  • This is useful to prevent incorrect behavior when a disconnect event arrives after a new connection request

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

@justtonytone
Copy link
Author

Requires dart-lang/tools#2305

@justtonytone justtonytone force-pushed the b-469149126-hot-reload-issues branch from 62b34de to 0f9621b Compare January 22, 2026 23:36
stack_trace: ^1.10.0
stream_channel: ^2.1.2
sse: ^4.1.2
sse: ^4.2.0
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would've expected this to fail since sse is only on 4.1.8, is there some kind of presubmit here that tries to run a build?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but we need to approve the workflows to run since you're not a trusted contributor on the repository. They'd definitely fail :)

- Update dwds to support ignoring disconnects for the SseHandler
- This is useful to prevent incorrect behavior when a disconnect event arrives after a new connection request
@justtonytone justtonytone force-pushed the b-469149126-hot-reload-issues branch from 0f9621b to b25b197 Compare January 23, 2026 21:07
@bkonyi bkonyi requested a review from nshahan January 28, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants