Fix DWDS injected client loading when running webdev in AOT mode#2768
Open
Varadraj75 wants to merge 1 commit intodart-lang:mainfrom
Open
Fix DWDS injected client loading when running webdev in AOT mode#2768Varadraj75 wants to merge 1 commit intodart-lang:mainfrom
Varadraj75 wants to merge 1 commit intodart-lang:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
Hey @nshahan, could you please review this PR when you get a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the DWDS injected debugging client fails to load when
webdevis installed and run in AOT mode (for example viadart pub global activate).In AOT snapshots, resolving the injected client using
Isolate.resolvePackageUrican fail, leading to the runtime error:Bad state: Cannot resolve "package:dwds/src/injected/client.js"To address this, the injected DWDS client is now served using an AOT-safe approach, avoiding runtime package URI resolution and ensuring the client is always available when serving
.bootstrap.jsentrypoints.This restores correct debugging behavior for globally activated
webdevwithout affecting existing JIT or development workflows.closes #2761