fix Hot restart/reload and service extension response deserialization error - #2771
Merged
Merged
Conversation
|
autosubmit label was removed for dart-lang/webdev/2771, because This PR has not met approval requirements for merging. The PR author is not a member of dart-team and needs 1 more review(s) in order to merge this PR.
|
bkonyi
approved these changes
Feb 9, 2026
| 'HotRestartRequest' => HotRestartRequest.fromJson(jsonData), | ||
| 'ServiceExtensionRequest' => ServiceExtensionRequest.fromJson(jsonData), | ||
| 'BuildResult' => BuildResult.fromJson(jsonData), | ||
| 'HotReloadResponse' => HotReloadResponse.fromJson(jsonData), |
Collaborator
There was a problem hiding this comment.
Do we have any tests that should have / could have caught this?
Contributor
Author
There was a problem hiding this comment.
I believe we have some E2E tests in Flutter_tools that would have caught it. Don't think we can implement these tests in DWDS since we need the client to be injected to establish the connection with DWDS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HotReloadResponse,HotRestartResponse, andServiceExtensionResponsein theDevHandler.Noticed issue in #2765
Fixes #2770