Skip to content

Prepare to publish #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 22, 2019
Merged

Prepare to publish #508

merged 5 commits into from
Jul 22, 2019

Conversation

grouma
Copy link
Member

@grouma grouma commented Jul 22, 2019

  • Update dwds's pubspec to include all deps
  • Update webdev / dwds to depend on latest build_daemon
  • Update webdev to restrict to proper build_runner version
  • Temporarily override example deps

@grouma grouma requested review from jakemac53 and natebosch July 22, 2019 17:27
natebosch
natebosch approved these changes Jul 22, 2019
View reviewed changes
dwds/pubspec.yaml Outdated
@@ -10,23 +10,34 @@ environment:
sdk: ">=2.3.2-dev.0.1 <3.0.0"

dependencies:
async: ^2.3.0
build: ^1.1.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically don't put the patch number in constraints, so ^1.1.0 here, ^4.2.0 for built_collection, etc...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change it. We really need to update pub.dev though because that's where I copy these values from.

@grouma grouma merged commit 105da9e into master Jul 22, 2019
@grouma grouma deleted the build-daemon-version branch July 22, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebosch natebosch natebosch approved these changes

@jakemac53 jakemac53 Awaiting requested review from jakemac53

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grouma @natebosch