Skip to content

Conversation

Trapov
Copy link
Contributor

@Trapov Trapov commented Jan 25, 2018

ended up doing this.
Issue -> #57

@dasMulli
Copy link
Owner

I don't really like the idea of adding a dependency on either .Hosting or .Hosting.Abstractions to the main package since it adds quite a lot of dlls to non-asp.net core projects.
Additionally, there will likely be updates to the hosting / abstractions that don't need to cause updates to the main service functionality. E.g. there will be a new hosting model in 2.1 (IHost vs IWebHost) and I still want the main package to work in both 2.0 and 2.1.

What do you think about making this its own nuget package? (I could do so after merging).

@Trapov
Copy link
Contributor Author

Trapov commented Jan 25, 2018

@dasMulli ya, i was thinking the same actually. but this feature doesn't really require the whole project, so it feels kinda bloated with not needed dependencies. It would be great if you could breake your project into different layers and then it would be really small and lightweight :)

but yes, i will update my PR and make this extension as a different project for now.

@dasMulli dasMulli merged commit f0b91e8 into dasMulli:master Jan 26, 2018
@Trapov
Copy link
Contributor Author

Trapov commented Jan 26, 2018

@dasMulli wait i haven't updated my PR still, i thought you wanted it as a separate project.

@dasMulli
Copy link
Owner

I'm on that already 😉

@Trapov
Copy link
Contributor Author

Trapov commented Jan 26, 2018

@dasMulli oh, ok, great then. feels like i dropped something that i had to do on you tho :)

@dasMulli
Copy link
Owner

see #59

@Trapov Trapov deleted the feature-aspnetcore-webhost-extension branch May 11, 2018 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants