Merge #6681: backport: bitcoin-core/gui#557, #552, #556, #590, #581, #608, #673, #676, #681, #690, #697, #717, #757, #751, #773, #801 (qt backports: part 4)

a41f4e7 merge bitcoin-core/gui#801: Fix nullptr clientModel access during shutdown (Kittywhiskers Van Gogh)
56fc672 merge bitcoin-core/gui#773: Check for private keys disabled before attempting unlock (Kittywhiskers Van Gogh)
ae0ca10 merge bitcoin-core/gui#751: macOS, do not process actions during shutdown (Kittywhiskers Van Gogh)
107a180 merge bitcoin-core/gui#757: Add wallet name to address book page title (Kittywhiskers Van Gogh)
9385d44 merge bitcoin-core/gui#717: Use the stored CSubNet entry when unbanning (Kittywhiskers Van Gogh)
fd651ee merge bitcoin-core/gui#697: Remove reindex special case from the progress bar label (Kittywhiskers Van Gogh)
8bdcd12 merge bitcoin-core/gui#690: Catch invalid networks combination crash (Kittywhiskers Van Gogh)
6cc422d merge bitcoin-core/gui#681: Fix Transaction Relay tooltip text in Peers details window (Kittywhiskers Van Gogh)
5c894e1 merge bitcoin-core/gui#676: Update peers window "Transaction Relay" label and tooltip (Kittywhiskers Van Gogh)
13990d8 merge bitcoin-core/gui#673: Use fallback value for Version and User Agent during peer connection (Kittywhiskers Van Gogh)
320f0e6 merge bitcoin-core/gui#608: Make `WalletModel::sendCoins()` return `void` (Kittywhiskers Van Gogh)
bb5b44e merge bitcoin-core/gui#581: Revamp `ClientModel` code to handle core signals (Kittywhiskers Van Gogh)
a334b68 merge bitcoin-core/gui#590: Declare `WalletModel` member functions with `const` (Kittywhiskers Van Gogh)
212e54d merge bitcoin-core/gui#556: Make BitcoinUnits::Unit a scoped enum (Kittywhiskers Van Gogh)
27951a3 merge bitcoin-core/gui#552: Refactor `TransactionDesc::FormatTxStatus` and `TransactionStatus` (Kittywhiskers Van Gogh)
054ffdb merge bitcoin-core/gui#557: revert bitcoin-core/gui#296 (Kittywhiskers Van Gogh)

Pull request description:

  ## Additional Information

  * Even though "DiplayBitcoinUnit" has been Dashified, the associated value is not (see below, from `~/.config/Dash/Dash-Qt-testnet.conf`) as renaming "BitcoinUnit" would cause significant conflicts when backporting, so it has retained its upstream name.

    ```
    DisplayDashUnit=@variant(\0\0\0\x7f\0\0\0\x13\x42itcoinUnits::Unit\0\0)
    ```

  * [bitcoin-core/gui#581](bitcoin-core/gui#581) affects three Dash-specific signal handlers, `m_handler_notify_additional_data_sync_progess_changed`, `m_handler_notify_chainlock` and `m_handler_notify_masternodelist_changed` and their refactoring needs to be specially reviewed.

  ## Breaking Changes

  None expected.

  ## Checklist

  - [x] I have performed a self-review of my own code **(note: N/A)**
  - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**
  - [x] I have added or updated relevant unit/integration/functional/e2e tests
  - [x] I have made corresponding changes to the documentation **(note: N/A)**
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  UdjinM6:
    light ACK a41f4e7

Tree-SHA512: 85e683beb2548e8d47a5c52b1ff802711b53c4432435f52c146ef6774edac6604fbc08365554ce23084bfb26f6ab9358df6ccae3d869c625510098cb3efc1471

Author: PastaPastaPasta

src/interfaces/node.h

@@ -235,11 +235,8 @@ class Node
     //! Is masternode.
     virtual bool isMasternode() = 0;
 
-    //! Get reindex.
-    virtual bool getReindex() = 0;
-
-    //! Get importing.
-    virtual bool getImporting() = 0;
+    //! Is loading blocks.
+    virtual bool isLoadingBlocks() = 0;
 
     //! Set network active.
     virtual void setNetworkActive(bool active) = 0;

src/node/interfaces.cpp

@@ -468,8 +468,7 @@ class NodeImpl : public Node
     {
         return m_context->mn_activeman != nullptr;
     }
-    bool getReindex() override { return ::fReindex; }
-    bool getImporting() override { return ::fImporting; }
+    bool isLoadingBlocks() override { return ::fReindex || ::fImporting; }
     void setNetworkActive(bool active) override
     {
         if (m_context->connman) {

src/qt/addressbookpage.cpp

@@ -71,9 +71,7 @@ AddressBookPage::AddressBookPage(Mode _mode, Tabs _tab, QWidget* parent) :
     ui->showAddressQRCode->setEnabled(false);
 #endif
 
-    switch(mode)
-    {
-    case ForSelection:
+    if (mode == ForSelection) {
         switch(tab)
         {
         case SendingTab: setWindowTitle(tr("Choose the address to send coins to")); break;
@@ -84,14 +82,6 @@ AddressBookPage::AddressBookPage(Mode _mode, Tabs _tab, QWidget* parent) :
         ui->tableView->setFocus();
         ui->closeButton->setText(tr("C&hoose"));
         ui->exportButton->hide();
-        break;
-    case ForEditing:
-        switch(tab)
-        {
-        case SendingTab: setWindowTitle(tr("Sending addresses")); break;
-        case ReceivingTab: setWindowTitle(tr("Receiving addresses")); break;
-        }
-        break;
     }
     switch(tab)
     {
@@ -162,6 +152,7 @@ void AddressBookPage::setModel(AddressTableModel *_model)
     connect(_model, &AddressTableModel::rowsInserted, this, &AddressBookPage::selectNewAddress);
 
     selectionChanged();
+    this->updateWindowsTitleWithWalletName();
 }
 
 void AddressBookPage::on_copyAddress_clicked()
@@ -347,3 +338,16 @@ void AddressBookPage::selectNewAddress(const QModelIndex &parent, int begin, int
         newAddressToSelect.clear();
     }
 }
+
+void AddressBookPage::updateWindowsTitleWithWalletName()
+{
+    const QString walletName = this->model->GetWalletDisplayName();
+
+    if (mode == ForEditing) {
+        switch(tab)
+        {
+        case SendingTab: setWindowTitle(tr("Sending addresses - %1").arg(walletName)); break;
+        case ReceivingTab: setWindowTitle(tr("Receiving addresses - %1").arg(walletName)); break;
+        }
+    }
+}

src/qt/addressbookpage.h

@@ -55,6 +55,7 @@ public Q_SLOTS:
     AddressBookSortFilterProxyModel *proxyModel;
     QMenu *contextMenu;
     QString newAddressToSelect;
+    void updateWindowsTitleWithWalletName();
 
 private Q_SLOTS:
     /** Delete currently selected address entry */

src/qt/addresstablemodel.cpp

@@ -448,3 +448,5 @@ void AddressTableModel::emitDataChanged(int idx)
 {
     Q_EMIT dataChanged(index(idx, 0, QModelIndex()), index(idx, columns.length()-1, QModelIndex()));
 }
+
+QString AddressTableModel::GetWalletDisplayName() const { return walletModel->getDisplayName(); };

src/qt/addresstablemodel.h

@@ -80,6 +80,8 @@ class AddressTableModel : public QAbstractTableModel
 
     EditStatus getEditStatus() const { return editStatus; }
 
+    QString GetWalletDisplayName() const;
+
 private:
     WalletModel* const walletModel;
     AddressTablePriv *priv = nullptr;

src/qt/bantablemodel.cpp

@@ -43,7 +43,7 @@ class BanTablePriv
     /** Order (ascending or descending) to sort nodes by */
     Qt::SortOrder sortOrder;
 
-    /** Pull a full list of banned nodes from CNode into our cache */
+    /** Pull a full list of banned nodes from interfaces::Node into our cache */
     void refreshBanlist(interfaces::Node& node)
     {
         banmap_t banMap;
@@ -181,3 +181,9 @@ bool BanTableModel::shouldShow()
 {
     return priv->size() > 0;
 }
+
+bool BanTableModel::unban(const QModelIndex& index)
+{
+    CCombinedBan* ban{static_cast<CCombinedBan*>(index.internalPointer())};
+    return ban != nullptr && m_node.unban(ban->subnet);
+}

src/qt/bantablemodel.h

@@ -37,7 +37,7 @@ class BannedNodeLessThan
 };
 
 /**
-   Qt model providing information about connected peers, similar to the
+   Qt model providing information about banned peers, similar to the
    "getpeerinfo" RPC call. Used by the rpc console UI.
  */
 class BanTableModel : public QAbstractTableModel
@@ -68,6 +68,8 @@ class BanTableModel : public QAbstractTableModel
 
     bool shouldShow();
 
+    bool unban(const QModelIndex& index);
+
 public Q_SLOTS:
     void refresh();
 

src/qt/bitcoin.cpp

@@ -97,6 +97,8 @@ static void RegisterMetaTypes()
     qRegisterMetaType<std::function<void()>>("std::function<void()>");
     qRegisterMetaType<QMessageBox::Icon>("QMessageBox::Icon");
     qRegisterMetaType<interfaces::BlockAndHeaderTipInfo>("interfaces::BlockAndHeaderTipInfo");
+
+    qRegisterMetaTypeStreamOperators<BitcoinUnit>("BitcoinUnit");
 }
 
 static QString GetLangTerritory()
@@ -346,6 +348,11 @@ void BitcoinApplication::requestShutdown()
     // Request node shutdown, which can interrupt long operations, like
     // rescanning a wallet.
     node().startShutdown();
+    // Prior to unsetting the client model, stop listening backend signals
+    if (clientModel) {
+        clientModel->stop();
+    }
+
     // Unsetting the client model can cause the current thread to wait for node
     // to complete an operation, like wait for a RPC execution to complete.
     window->setClientModel(nullptr);
@@ -564,29 +571,30 @@ int GuiMain(int argc, char* argv[])
     // Gracefully exit if the user cancels
     if (!Intro::showIfNeeded(did_show_intro, prune_MiB)) return EXIT_SUCCESS;
 
-    /// 6. Determine availability of data directory and parse dash.conf
-    /// - Do not call gArgs.GetDataDirNet() before this step finishes
+    /// 6a. Determine availability of data directory
     if (!CheckDataDirOption()) {
         InitError(strprintf(Untranslated("Specified data directory \"%s\" does not exist.\n"), gArgs.GetArg("-datadir", "")));
         QMessageBox::critical(nullptr, PACKAGE_NAME,
             QObject::tr("Error: Specified data directory \"%1\" does not exist.").arg(QString::fromStdString(gArgs.GetArg("-datadir", ""))));
         return EXIT_FAILURE;
     }
-    if (!gArgs.ReadConfigFiles(error, true)) {
-        InitError(strprintf(Untranslated("Error reading configuration file: %s\n"), error));
-        QMessageBox::critical(nullptr, PACKAGE_NAME,
-            QObject::tr("Error: Cannot parse configuration file: %1.").arg(QString::fromStdString(error)));
-        return EXIT_FAILURE;
-    }
+    try {
+        /// 6b. Parse dash.conf
+        /// - Do not call gArgs.GetDataDirNet() before this step finishes
+        if (!gArgs.ReadConfigFiles(error, true)) {
+            InitError(strprintf(Untranslated("Error reading configuration file: %s\n"), error));
+            QMessageBox::critical(nullptr, PACKAGE_NAME,
+                QObject::tr("Error: Cannot parse configuration file: %1.").arg(QString::fromStdString(error)));
+            return EXIT_FAILURE;
+        }
 
-    /// 7. Determine network (and switch to network specific options)
-    // - Do not call Params() before this step
-    // - Do this after parsing the configuration file, as the network can be switched there
-    // - QSettings() will use the new application name after this, resulting in network-specific settings
-    // - Needs to be done before createOptionsModel
+        /// 7. Determine network (and switch to network specific options)
+        // - Do not call Params() before this step
+        // - Do this after parsing the configuration file, as the network can be switched there
+        // - QSettings() will use the new application name after this, resulting in network-specific settings
+        // - Needs to be done before createOptionsModel
 
-    // Check for -chain, -testnet or -regtest parameter (Params() calls are only valid after this clause)
-    try {
+        // Check for -chain, -testnet or -regtest parameter (Params() calls are only valid after this clause)
         SelectParams(gArgs.GetChainName());
     } catch(std::exception &e) {
         InitError(Untranslated(strprintf("%s\n", e.what())));

src/qt/bitcoinamountfield.cpp

@@ -12,13 +12,16 @@
 #include <QHBoxLayout>
 #include <QKeyEvent>
 #include <QLineEdit>
+#include <QVariant>
+
+#include <cassert>
 
 /**
  * Parse a string into a number of base monetary units and
  * return validity.
  * @note Must return 0 if !valid.
  */
-static CAmount parse(const QString &text, int nUnit, bool *valid_out= nullptr)
+static CAmount parse(const QString &text, BitcoinUnit nUnit, bool *valid_out= nullptr)
 {
     CAmount val = 0;
     bool valid = BitcoinUnits::parse(nUnit, text, &val);
@@ -37,11 +40,12 @@ static CAmount parse(const QString &text, int nUnit, bool *valid_out= nullptr)
 class AmountValidator : public QValidator
 {
     Q_OBJECT
-    int currentUnit;
+    BitcoinUnit currentUnit;
+
 public:
     explicit AmountValidator(QObject *parent) :
         QValidator(parent),
-        currentUnit(BitcoinUnits::DASH) {}
+        currentUnit(BitcoinUnit::DASH) {}
 
     State validate(QString &input, int &pos) const override
     {
@@ -53,7 +57,7 @@ class AmountValidator : public QValidator
         return valid ? QValidator::Intermediate : QValidator::Invalid;
     }
 
-    void updateUnit(int nUnit)
+    void updateUnit(BitcoinUnit nUnit)
     {
         currentUnit = nUnit;
     }
@@ -69,7 +73,7 @@ class AmountLineEdit: public QLineEdit
 public:
     explicit AmountLineEdit(QWidget *parent):
         QLineEdit(parent),
-        currentUnit(BitcoinUnits::DASH)
+        currentUnit(BitcoinUnit::DASH)
     {
         setAlignment(Qt::AlignLeft);
         amountValidator = new AmountValidator(this);
@@ -122,7 +126,7 @@ class AmountLineEdit: public QLineEdit
         m_max_amount = value;
     }
 
-    void setDisplayUnit(int unit)
+    void setDisplayUnit(BitcoinUnit unit)
     {
         bool valid = false;
         CAmount val = value(&valid);
@@ -142,14 +146,14 @@ class AmountLineEdit: public QLineEdit
         ensurePolished();
         const QFontMetrics fm(fontMetrics());
         int h = 0;
-        int w = GUIUtil::TextWidth(fm, BitcoinUnits::format(BitcoinUnits::DASH, BitcoinUnits::maxMoney(), false, BitcoinUnits::SeparatorStyle::ALWAYS));
+        int w = GUIUtil::TextWidth(fm, BitcoinUnits::format(BitcoinUnit::DASH, BitcoinUnits::maxMoney(), false, BitcoinUnits::SeparatorStyle::ALWAYS));
         w += 2; // cursor blinking space
         w += GUIUtil::dashThemeActive() ? 24 : 0; // counteract padding from css
         return QSize(w, h);
     }
 
 private:
-    int currentUnit{BitcoinUnits::DASH};
+    BitcoinUnit currentUnit{BitcoinUnit::DASH};
     bool m_allow_empty{true};
     CAmount m_min_amount{CAmount(0)};
     CAmount m_max_amount{BitcoinUnits::maxMoney()};
@@ -287,14 +291,13 @@ void BitcoinAmountField::unitChanged(int idx)
     amount->setToolTip(units->data(idx, Qt::ToolTipRole).toString());
 
     // Determine new unit ID
-    int newUnit = units->data(idx, BitcoinUnits::UnitRole).toInt();
-
-    amount->setPlaceholderText(tr("Amount in %1").arg(units->data(idx,Qt::DisplayRole).toString()));
-
-    amount->setDisplayUnit(newUnit);
+    QVariant new_unit = units->data(idx, BitcoinUnits::UnitRole);
+    assert(new_unit.isValid());
+    amount->setPlaceholderText(tr("Amount in %1").arg(units->data(idx, Qt::DisplayRole).toString()));
+    amount->setDisplayUnit(new_unit.value<BitcoinUnit>());
 }
 
-void BitcoinAmountField::setDisplayUnit(int newUnit)
+void BitcoinAmountField::setDisplayUnit(BitcoinUnit new_unit)
 {
-    unitChanged(newUnit);
+    unitChanged(QVariant::fromValue(new_unit).toInt());
 }