refactor: remove all the unneeded and unused (probably broken) travis stuff #4621
Conversation
|
No, imo we probably shouldn't since they are a part of git subtrees. |
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
Pretty sure there is a PR to backport for this but utACK :)
kwvg
left a comment
kwvg
left a comment
There was a problem hiding this comment.
Postmortem NACK.
Even if we don't use it, it is a part of the official source tree and it interferes with reconciling the differences between Dash's and Bitcoin's CI system, efforts for which were ongoing. Proposing a revert.
|
post-NACK I will have to agree with kittywhiskers on this, after looking through Bitcoin's repo, i found the backport that Udjin was referring too, however it mostly renames and reworks travis. bitcoin#16582 is the first in a long series of CI changes involving travis. While their end goal is to be able to drop travis at a moment's notice, ci changes are easier to deal with if we don't drop it yet. |
|
Feel free to revert this as part of a future PR if you intend to actually unify our build system, but we shouldn't keep an unsupported ci system just because it exists, just as we don't have a number of rbf related files that bitcoin does, because we don't support them, and they'd probably be broken. |
|
This branch was originally going to be part of the Docker PR but since it was too differing in scope, it was separated. This PR causes conflicts in #4336 so it'll need to be reverted, will do so in #4336. |
4 participants
We don't use travis. There's no need to continue having this in the repo.
tested via
git grep "travis"