Skip to content

Overriding blosc threads #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakirkham opened this issue May 3, 2017 · 6 comments
Closed

Overriding blosc threads #1054

jakirkham opened this issue May 3, 2017 · 6 comments
Labels
enhancement Improve existing functionality or make things work better good second issue Clearly described, educational, but less trivial than "good first issue".

Comments

@jakirkham
Copy link
Member

Would be nice to expose to the user a way to set the number of threads to use with blosc. Suggested options would be a config file setting and some Python API to do this. Both would be great.

xref: #606 (review)

@mrocklin
Copy link
Member

mrocklin commented May 9, 2017

An entry in the config file sounds good to me. Client.run could probably handle the Python API in a pinch.

def f(nthreads, dask_worker=None):
    import blosc
    blosc.set_nthreads(nthreads)

client.run(f, 4)

@jakirkham
Copy link
Member Author

So now that the config is revamped, how might one go about moving this parameter into the config?

@mrocklin
Copy link
Member

Replace this line in distributed/protocol/compression.py:

n = blosc.set_nthreads(2)

With something like this?

n = blosc.set_nthreads(dask.config.get('distributed.comm.blosc.nthreads`)) 

And then add a suitable entry to distributed/distributed.yaml

@jakirkham
Copy link
Member Author

What about adding it to the config?

@mrocklin
Copy link
Member

mrocklin commented Nov 2, 2018

Yes, I think that that's a good idea

@GenevieveBuckley GenevieveBuckley added enhancement Improve existing functionality or make things work better good second issue Clearly described, educational, but less trivial than "good first issue". labels Oct 15, 2021
@jakirkham
Copy link
Member Author

Closing as Blosc was dropped ( #6027 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or make things work better good second issue Clearly described, educational, but less trivial than "good first issue".
Projects
None yet
Development

No branches or pull requests

3 participants