Skip to content

linalg.vecdot and vecdot have (midly) diverging defaults. #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lezcano opened this issue Dec 31, 2021 · 3 comments · Fixed by #358
Closed

linalg.vecdot and vecdot have (midly) diverging defaults. #355

lezcano opened this issue Dec 31, 2021 · 3 comments · Fixed by #358
Assignees
@kgryte
Labels
bug Something isn't working. topic: Linear Algebra Linear algebra.
Milestone
v2021

Comments

@lezcano
Copy link
Contributor

lezcano commented Dec 31, 2021 •
edited
Loading

Their signatures are:
linalg.vecdot(x1, x2, /, *, axis=None)

vecdot(x1, x2, /, *, axis=-1)

I'd certainly prefer to settle for axis=-1.
@rgommers rgommers added this to the v2021 milestone Dec 31, 2021
@rgommers rgommers added topic: Linear Algebra Linear algebra. bug Something isn't working. labels Dec 31, 2021
@rgommers
Copy link
Member

Ouch, that seems like a bug to me, good catch @lezcano.

@asmeurer
Copy link
Member

asmeurer commented Jan 3, 2022

I think this was just an oversight #281

@kgryte kgryte mentioned this issue Jan 5, 2022
Merged
@kgryte
Copy link
Contributor

kgryte commented Jan 5, 2022

This has been addressed in #358.

@kgryte kgryte mentioned this issue May 3, 2024
Closed
kgryte added a commit to kgryte/array-api that referenced this issue Jan 9, 2025
@kgryte
fix: address default value regression for axis kwarg in vecdot
d610848 
Closes: data-apis#804
Ref: data-apis#355
Ref: data-apis#358
Ref: data-apis@cbbab62
kgryte added a commit that referenced this issue Jan 9, 2025
@kgryte
fix: address default value regression for axis kwarg in vecdot
fd6f507 
PR-URL: #880
Closes: #804
Ref: #355
Ref: #358
Ref: cbbab62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kgryte kgryte

Labels
bug Something isn't working. topic: Linear Algebra Linear algebra.
Projects
None yet
Milestone
v2021
Development

Successfully merging a pull request may close this issue.

Fix signature for linalg.vecdot data-apis/array-api
4 participants
@asmeurer @rgommers @kgryte @lezcano