-
Notifications
You must be signed in to change notification settings - Fork 52
Add element-wise function specifications, incl. type casting and broadcasting rules #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That's a good question. I'd prefer requiring Although some may have a use case for
My mental model is that those shapes should be equal, and hence |
@rgommers Thanks for the feedback. Re: broadcasting. My understanding is that, e.g., NumPy permits such broadcasting semantics. |
Based on discussion here: #8 (comment)
I've updated the proposed specification to include supported data types and promotion rules, which should now roughly complete the spec for element-wise functions. Remaining concerns include:
However, these concerns can be addressed in follow-up PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kgryte. I think this is in good shape, and all the important decisions have been reviewed by multiple people in the various linked issues and meetings.
Let's go ahead and merge this.
This PR