Add specification for computing a tensor contraction (linalg: tensordot) #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
force-pushed
the
main
branch
3 times, most recently
from
0607525 to
138e963
Compare
|
This PR has been open for some time without comment and discussed/approved during meetings. Will merge and we can submit follow-up PRs should any issues/concerns arise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Notes
JAX supports providing a
precisionkeyword argument to control matrix-multiplication precision. It is alone in doing so among compared array libraries.TF allows providing a
(2,K)shapedarrayfor theaxeskeyword argument. NumPy et al support array-like values or lists when specifying multiple axes. This proposal follows NumPy et al in only allowingintandSequence.TF returns an array whose data type is that of
x1. This proposal requires that the result follow type promotion rules.